Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert TZ target name to test spec platform name #11467

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Convert TZ target name to test spec platform name #11467

merged 1 commit into from
Sep 12, 2019

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Sep 12, 2019

Description

Originally, only the conversion of PSA non-secure target name to test spec platform name is supported for Greentea. This PR extends it by converting all TZ target names to test spec platform name:

  1. All TZ targets should have name pattern: PLATFORM_[PSA_]S/NS, where:
    1. PLATFORM for test spe platform name registered in mbed-os-tools
    2. PSA is optional to distinguish PSA/non-PSA targets, especially when both PSA/non-PSA targets are supported
    3. S/NS for secure/non-secure targets
  2. Secure target may participate in Greentea, so its name is also converted here.

Related PR

Split from #11288

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond

@ccli8
Convert TZ target name to test spec platform name
a489a73 
1.  All TZ targets should have name pattern: PLATFORM_[PSA_]S/NS, where:
    (1) 'PLATFORM' for test spec platform name
    (2) 'PSA' is optional to distinguish PSA/non-PSA targets, especially when
        both PSA/non-PSA targets are supported
    (3) 'S'/'NS' for secure/non-secure targets
2. Secure target may participate in Greentea, so its name is also truncated here.
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 12, 2019

Split from #11288

Is this required - dependency ? to understand the release version for this one

@ccli8 ccli8 mentioned this pull request Sep 12, 2019
Merged
@ccli8
Copy link
Contributor Author

ccli8 commented Sep 12, 2019

Is this required - dependency ? to understand the release version for this one

Yes. #11288 depends on this PR.

@ciarmcom ciarmcom requested review from jamesbeyond and a team September 12, 2019 07:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@jamesbeyond @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 12, 2019

Adding label 5.14.0-rc2

cc @adbridge

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 01bb1b9 into ARMmbed:master Sep 12, 2019
@ccli8 ccli8 deleted the nuvoton_conv_tz_test_spec branch September 12, 2019 10:57
jamesbeyond
jamesbeyond reviewed Sep 12, 2019
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ccli8 ccli8 mentioned this pull request Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbeyond jamesbeyond jamesbeyond left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @0xc0170 @ciarmcom @mbed-ci @jamesbeyond